RANGER-5005: Use sortpom maven plugin to improve readability of pom files #418
Conversation
mneethiraj
requested review from
rameeshm,
pradeepagrawal8184,
mehulbparikh,
vperiasamy,
fateh288,
kumaab,
kishorgollapalliwar and
spolavarpau1
| <description>Kylin Security Plugin</description> | ||
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| </properties> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.apache.calcite</groupId> | ||
| <artifactId>calcite-linq4j</artifactId> | ||
| <version>1.16.0</version> |
There was a problem hiding this comment.
minor: can be kept in a variable, may be subsequent patch?
| <version>${cglib.version}</version> | ||
| <groupId>com.google.inject</groupId> | ||
| <artifactId>guice</artifactId> | ||
| <version>3.0</version> |
There was a problem hiding this comment.
minor: can be kept in a variable.
| <dependency> | ||
| <groupId>com.sun.xml.security</groupId> | ||
| <artifactId>xml-security-impl</artifactId> | ||
| <version>1.0</version> |
There was a problem hiding this comment.
minor: can be kept in a variable.
| <dependency> | ||
| <groupId>org.apache.directory.api</groupId> | ||
| <artifactId>api-i18n</artifactId> | ||
| <version>1.0.3</version> |
There was a problem hiding this comment.
minor: can be kept in a variable.
| <dependency> | ||
| <groupId>jakarta.ws.rs</groupId> | ||
| <artifactId>jakarta.ws.rs-api</artifactId> | ||
| <version>2.1.6</version> |
There was a problem hiding this comment.
Jakarta apis will replace javax apis going forward, we can keep this in root pom.xml
| <version>${junit.jupiter.version}</version> | ||
| <groupId>com.mycila.xmltool</groupId> | ||
| <artifactId>xmltool</artifactId> | ||
| <version>3.3</version> |
There was a problem hiding this comment.
minor: can be kept in a variable.
| <version>${junit.jupiter.version}</version> | ||
| <groupId>io.rest-assured</groupId> | ||
| <artifactId>rest-assured</artifactId> | ||
| <version>3.0.3</version> |
There was a problem hiding this comment.
minor: can be kept in a variable.
| <dependency> | ||
| <groupId>org.eclipse.jdt.core.compiler</groupId> | ||
| <artifactId>ecj</artifactId> | ||
| <version>P20140317-1600</version> |
There was a problem hiding this comment.
minor: can be kept in a variable.
| <groupId>org.apache.avro</groupId> | ||
| <artifactId>avro</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.tez</groupId> | ||
| <artifactId>tez-dag</artifactId> | ||
| <version>0.9.1</version> |
There was a problem hiding this comment.
minor: can be kept in a variable.
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.3</version> |
There was a problem hiding this comment.
minor: can be kept in a variable.
| <dependency> | ||
| <groupId>javax.inject</groupId> | ||
| <artifactId>javax.inject</artifactId> | ||
| <version>1</version> |
There was a problem hiding this comment.
minor: can be kept in a variable.
| @@ -888,10 +885,10 @@ | |||
| <version>1.5.3</version> | |||
There was a problem hiding this comment.
minor: can be kept in a variable.
| <dependency> | ||
| <groupId>javax.jws</groupId> | ||
| <artifactId>javax.jws-api</artifactId> | ||
| <version>1.1</version> |
There was a problem hiding this comment.
minor: can be kept in a variable.
What changes were proposed in this pull request?
This PR is ranger-2.6 branch equivalent of PR #413.
Keeping pom.xml file contents sorted will improve readability. This PR uses sortpom maven plugin to enforce that pom.xml file contents are in sorted order.
How was this patch tested?
Build with unit tests completed successfully.