Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic in SendResult.String() when MessageQueue is nil #1124

Open
MaOreoreorui opened this issue Dec 27, 2023 · 0 comments
Open

Panic in SendResult.String() when MessageQueue is nil #1124

MaOreoreorui opened this issue Dec 27, 2023 · 0 comments

Comments

@MaOreoreorui
Copy link
Contributor

BUG REPORT

  1. Please describe the issue you observed:

    • What did you do (The steps to reproduce)?
      The String() method in SendResult cause a panic when MessageQueue field is nil. This happens beacuse String() method tries to access MessageQueue.String() without checking if MessageQueue is nil.

    • What did you expect to see?
      The String() method should not panic, even when MessageQueue is nil. Instead, it should return a string that clearly indicates MessageQueue is nil.
MaOreoreorui pushed a commit to MaOreoreorui/rocketmq-client-go that referenced this issue Dec 27, 2023
fix: panic in SendResult.String (apache#1124)
7a89bba
francisoliverlee added a commit that referenced this issue Mar 6, 2024
@francisoliverlee
Merge pull request #1125 from MaOreoreorui/master
f4875c1 
[ISSUE #1124] fix: panic in SendResult.String
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MaOreoreorui