diff --git a/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java b/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java index 1883574241b..2daa95b9bc0 100644 --- a/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java +++ b/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java @@ -168,11 +168,7 @@ public RemotingCommand putKVConfig(ChannelHandlerContext ctx, response.setRemark("namespace or key is null"); return response; } - if (validateBlackListConfigExist(requestHeader.getKey())) { - response.setCode(ResponseCode.NO_PERMISSION); - response.setRemark("Can not update config in black list."); - return response; - } + this.namesrvController.getKvConfigManager().putKVConfig( requestHeader.getNamespace(), requestHeader.getKey(), @@ -686,7 +682,4 @@ private boolean validateBlackListConfigExist(Properties properties) { return false; } - private boolean validateBlackListConfigExist(String key) { - return configBlackList.contains(key); - } } diff --git a/namesrv/src/test/java/org/apache/rocketmq/namesrv/processor/RequestProcessorTest.java b/namesrv/src/test/java/org/apache/rocketmq/namesrv/processor/RequestProcessorTest.java index eddc5e11de1..2b2cf629494 100644 --- a/namesrv/src/test/java/org/apache/rocketmq/namesrv/processor/RequestProcessorTest.java +++ b/namesrv/src/test/java/org/apache/rocketmq/namesrv/processor/RequestProcessorTest.java @@ -110,19 +110,6 @@ public void testProcessRequest_PutKVConfig() throws RemotingCommandException { assertThat(namesrvController.getKvConfigManager().getKVConfig("namespace", "key")) .isEqualTo("value"); - - // use key in black list - RemotingCommand requestFailed = RemotingCommand.createRequestCommand(RequestCode.PUT_KV_CONFIG, - header); - requestFailed.addExtField("namespace", "namespace"); - requestFailed.addExtField("key", "configBlackList"); - requestFailed.addExtField("value", "value"); - - RemotingCommand responseFailed = defaultRequestProcessor.processRequest(null, requestFailed); - - assertThat(responseFailed).isNotNull(); - assertThat(responseFailed.getCode()).isEqualTo(ResponseCode.NO_PERMISSION); - assertThat(responseFailed.getRemark()).contains("Can not update config in black list."); } @Test