Replies: 1 comment 1 reply
-
|
Agree. Do it! |
Beta Was this translation helpful? Give feedback.
1 reply
-
Yes, I will submit this change if the community thinks it can be done |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
There are many functions in the current code that need to pass arguments, but the arguments are not used. The current discovery is mainly in the DefaultRequestProcessor in nameserver. It's a similar story elsewhere.
From a coding point of view, I don't think this makes sense. I understand that this parameter should be passed for future use. But it has not been used for a long time.
So, I think from a code optimization point of view, invalid parameter passing should be removed. Pass parameters as needed.
I'd like to hear from the community.
eg:
Beta Was this translation helpful? Give feedback.
All reactions