-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand unit tests for ShardingSphereDatabase class #28646
Conversation
.../test/java/org/apache/shardingsphere/infra/metadata/database/ShardingSphereDatabaseTest.java
Outdated
Show resolved
Hide resolved
Quick question: How could I run the checkstyle and spotless in my dev env ? |
./mvnw clean install -DskipTests -Pcheck |
Thanks, I am able to run the checkstyle check, but when I executed I am wondering is there anything else I should configure before this usage? I am using codespaces created from my fork |
You can refer to https://shardingsphere.apache.org/community/cn/involved/conduct/code/ |
I have executed the same command
Second execution of this workflow is triggered by a newer commit |
Notes
This PR fixes - #28568
Changes proposed in this pull request contains unit tests for the following methods in
ShardingSphereDatabase
classcontainsSchema
getSchema
addSchema
dropSchema
containsDataSource
Unit tests for the static
create
method will be included in a follow-up PRTesting
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e
.