Skip to content

Refactor AutoTableRuleSegment to maintain similarity with TableRuleSegment #35101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactor AutoTableRuleSegment to maintain similarity with TableRuleSegment #35101

wants to merge 3 commits into from

Conversation

@Yash-cor
Copy link
Contributor

@Yash-cor Yash-cor commented Mar 28, 2025 •
edited
Loading

Changes proposed in this pull request:

Refactor AutoTableRuleSegment to maintain similarity with TableRuleSegment for clean code.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@yx9o yx9o added this to the 5.5.3 milestone Mar 31, 2025
@Yash-cor
Copy link
Contributor Author

Ni Hao, @yx9o could you review this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature: DistSQL type: refactor

Projects

None yet

Milestone

5.5.3

Development

Successfully merging this pull request may close these issues.

2 participants

@Yash-cor @yx9o