Replies: 5 comments
-
@mrproliu Here is another proposal. |
Beta Was this translation helpful? Give feedback.
-
Yes, we can do this. Please go ahead on this, thanks. |
Beta Was this translation helpful? Give feedback.
-
Don't mention it. The tracepoints for syscalls are quite numerous. To avoid introducing issues with the modifications, I need some additional time to carefully make adjustments. |
Beta Was this translation helpful? Give feedback.
-
I could move this as there is not estimated time and plan for this. |
Beta Was this translation helpful? Give feedback.
-
I have corrected all the function parameters of the tracepoints, referring to the implementation of the kernel trace module (include/trace/events/) and the modifications in Inspektor Gadget (https://github.com/inspektor-gadget/inspektor-gadget/pull/2546/files#diff-96e60e3018b9a342424db64d9cc8a0f3c3307410932647b7c6e25f5e64c2ef6c). The parameters based on BTF information ensure that data can be accessed at the correct offset. A notable case is the modification of syscall group function parameters. Instead of using |
Beta Was this translation helpful? Give feedback.
-
Search before asking
Description
Referencing this issue comment, to avoid the impact of buggy kernels, it is recommended to use
struct syscall_trace_exit
to prevent issues where incorrect offset calculations lead to the verifier rejecting the BPF progs loading.Use case
replace
struct trace_point_common_exit
withstruct syscall_trace_exit
Related issues
No response
Are you willing to submit a pull request to implement this on your own?
Code of Conduct
Beta Was this translation helpful? Give feedback.
All reactions