[ENH] Skywalking-CLI --debug posts ASF License into every POST message

[verbunk]

Hey Folks,

Hoping to submit this as a potential ENH for skywalking-cli. When using --debug the logs fill with the ASF license over and over. Example,

$> swctl --debug --config ~/.config/skywalk/skywalking.yml logs ls
DEBUG Debug mode is enabled                        
DEBUG Using configurations:
base-url: <redacted>
grpc-addr: <redacted>
DEBUG >> variables: map[]                          
DEBUG >> query: # Licensed to Apache Software Foundation (ASF) under one or more contributor
# license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright
# ownership. Apache Software Foundation (ASF) licenses this file to you under
# the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied.  See the License for the
# specific language governing permissions and limitations
# under the License.

query {
    result: getTimeInfo {
        timezone, currentTimestamp
    }
} 
DEBUG >> headers: map[Accept:[application/json; charset=utf-8] Content-Type:[application/json; charset=utf-8]] 
DEBUG << {"data":{"result":{"timezone":"+0000","currentTimestamp":1660093001592}}} 
DEBUG Start time:  end time:  timezone:            
DEBUG >> variables: map[condition:0xc00083c100]    
DEBUG >> query: # Licensed to Apache Software Foundation (ASF) under one or more contributor
# license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright
# ownership. Apache Software Foundation (ASF) licenses this file to you under
# the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied.  See the License for the
# specific language governing permissions and limitations
# under the License.

query ($condition: LogQueryCondition!) {
    result: queryLogs(condition: $condition) {
        total
        logs {
            serviceName
            serviceId
            serviceInstanceName
            serviceInstanceId
            endpointName
            endpointId
            traceId
            timestamp
            contentType
            content
            tags {
                key
                value
            }
        }
    }
} 
DEBUG >> headers: map[Accept:[application/json; charset=utf-8] Content-Type:[application/json; charset=utf-8]]

I'm not sure about the rules of ASF licensing ... but I don't think this is necessary. Thoughts?

[wu-sheng]

I think this is caused by query template having this header?
The header for source files(including template file) is required.

@kezhenxu94 Anything we can do to avoid this for runtime?

[kezhenxu94]

I think this is caused by query template having this header? The header for source files(including template file) is required.

@kezhenxu94 Anything we can do to avoid this for runtime?

This kind of logs are printed "as is" by the GraphQL SDK, we have to strip the headers after reading the query file content.

[wu-sheng]

Is this file user editable? If so, they could remove on their own at least.

[kezhenxu94]

Is this file user editable? If so, they could remove on their own at least.

This is bundled in our binary, so I don't think so

[wu-sheng]

OK, @verbunk Then this can't be discarded easily. You have to change the source codes to remove the header.