[SPARK-50433][DOCS][TEST] Fix confguring log4j2 guide docs for Spark on YARN and UT #48981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
commented
Nov 27, 2024
| @@ -74,7 +74,7 @@ object IntegrationTestUtils { | |||
|
|
|||
| // Redirect server log into console | |||
| "--conf", | |||
| s"spark.driver.extraJavaOptions=-Dlog4j.configuration=$log4j2") | |||
| s"spark.driver.extraJavaOptions=-Dlog4j.configurationFile=$log4j2") | |||
There was a problem hiding this comment.
LOG4J2 should only respect log4j.configurationFile, I'm not sure how the previous code worked. cc @zhenlineo
|
cc @viirya |
viirya
reviewed
Nov 27, 2024
Co-authored-by: Liang-Chi Hsieh <[email protected]>
viirya
reviewed
Nov 29, 2024
| @@ -293,7 +293,7 @@ class YarnClusterSuite extends BaseYarnClusterSuite { | |||
| } | |||
|
|
|||
| test("running Spark in yarn-cluster mode displays driver log links") { | |||
| val log4jConf = new File(tempDir, "log4j.properties") | |||
| val log4jConf = new File(tempDir, "log4j2.properties") | |||
There was a problem hiding this comment.
Note that this test actually uses configurationFile so no matter what the filename of properties file is.
There was a problem hiding this comment.
yes, the renaming is just for consistency
viirya
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As title.
Why are the changes needed?
SPARK-37814 (3.3.0) migrated logging system from log4j1 to log4j2, we should updated the docs as well.
Does this PR introduce any user-facing change?
Yes, docs are updated.
How was this patch tested?
Review.
Was this patch authored or co-authored using generative AI tooling?
No.