Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up on ace library fix to fix Markdown with Emoji issue #11475

Closed
zuzana-vej opened this issue Oct 29, 2020 · 8 comments
Closed

Follow up on ace library fix to fix Markdown with Emoji issue #11475

zuzana-vej opened this issue Oct 29, 2020 · 8 comments
Labels
dashboard:markdown Related to the markdown component of the Dashboard enhancement:request Enhancement request submitted by anyone from the community

Comments

@zuzana-vej
Copy link
Contributor

As per conclusion in this bug #11331 this enhancement request is just a reminder to wait for a fix in the Ace Editor and validate it fully fixes the bug with Shifting cursor (forward) when editing Markdown with emoji.
@zuzana-vej zuzana-vej added the enhancement:request Enhancement request submitted by anyone from the community label Oct 29, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #enhancement to this issue, with a confidence of 0.83. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@nytai
Copy link
Member

nytai commented Oct 29, 2020

Have we opened an issue with https://github.com/ajaxorg/ace?

@zuzana-vej
Copy link
Contributor Author

I haven't. @kkucharc have you / if not could you please open one since you discovered issue is with that?

@mistercrunch
Copy link
Member

mistercrunch commented Oct 29, 2020 •
edited
Loading

Did we check that we're on the latest Ace, sometimes bumping to latest version addresses little bugs like this one?

@nytai
Copy link
Member

nytai commented Oct 29, 2020

@mistercrunch yes, it appears it's broken in their demo too (as per #11331)

@mistercrunch
Copy link
Member

Gotcha. I just looked and our react-ace is super behind though. It moved from being based on brace to something new ace-builds.

@junlincc
Copy link
Member

@kkucharc asked in Ace editor issue about any news in that. Upgrading react-ace to 9.2.0 didn’t help.

added Markdown component to roadmap inbox
https://github.com/apache-superset/superset-roadmap/projects/1

@kkucharc
Copy link
Contributor

I asked in this issue about any news in the topic: ajaxorg/ace#4142

@zuzana-vej zuzana-vej added the dashboard:markdown Related to the markdown component of the Dashboard label Apr 21, 2021
@apache apache locked and limited conversation to collaborators Feb 2, 2022
@geido geido converted this issue into discussion #18413 Feb 2, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees
No one assigned
Labels
dashboard:markdown Related to the markdown component of the Dashboard enhancement:request Enhancement request submitted by anyone from the community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mistercrunch @kkucharc @nytai @zuzana-vej @junlincc