Skip to content

Conversation

@jbampton
Copy link
Member

@jbampton jbampton commented Nov 5, 2025

Add license header and fill out config and add two more "meta" hooks

Add license header and fill out config and add two more "meta" hooks
@sbp
Copy link
Contributor

sbp commented Nov 6, 2025

@jbampton I usually commit and then push straight away. It's very rare that I would commit multiple and then push, or commit and then push much later, so I think we should use commit only, which I believe is the default?

For minimum_pre_commit_version, I think we should just omit it, because what if people want to use prek? Or does prek ignore this field? It's good to pin or narrow version ranges, but I'm not sure what our minimum actual dependency on pre-commit is here.

For some reason the identity check prints a list of every single file in the repo. Is there a way to turn that behaviour off?

@jbampton
Copy link
Member Author

jbampton commented Nov 6, 2025

I just saw the identity hook is actually a debugging hook. Looks like we could remove this.

https://pre-commit.com/#meta-identity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants