-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELAX][BYOC] OpenCLML offload support for Relax #17654
Conversation
|
||
# Verify codegen | ||
clml_mod = OpenCLMLOffLoad()(clml_mod) | ||
verify_codegen(clml_mod, clml_codegen) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do codegen check here (JSON comparison).
clml_mod = OpenCLMLOffLoad()(clml_mod) | ||
verify_codegen(clml_mod, clml_codegen) | ||
|
||
# On Mainline CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainline will not have rpc, Hence we don't proceed beyond this point
@Hzfengsy for the
|
Thanks for pinging me. @srkreddy1238
IIUC it works as a CLML-specific pass. If so, could you please move it under adreno or clml folders, or at least add comments saying that it works only for CLML. |
This is not CLML specific. Can be used for fusing Conv2D+BN -> Conv2D (Updated weight, bias) for inference case. |
0b220c8
to
d65a89a
Compare
Note on this pass. This was an optimization can indeed can apply more broadly. One note is that this optimization is a special case of FoldScaleAxis optimization that folds scale into weights, so we want to add a comment here that we can replace by general FoldScaleAxis in future, cc @Hzfengsy @srkreddy1238 |
Thanks @srkreddy1238 for great effort, glad to see the new target aware pipeline helps to simplify the flow here. also cc @MasterJH5574 |
This brings in OpenCLML offloading via BYOC path with available operators in Relax. Adds codegen tests for Mainline CI.
2f37eb9
to
ea742a1
Compare
Thanks @srkreddy1238 this is merged! |
The codegen tests are added in unity->gpu. But I see this CI pipeline only builds GPU but doesn't run tests. Is this expected to be enabled soon ? |
https://github.com/apache/tvm/blob/main/ci/jenkins/unity_jenkinsfile.groovy#L356 the build stage of unity pipeline does run relax tests. We can also followup to fold unity pipeline into the normal gpu pipeline |
This brings in OpenCLML offloading via BYOC path with available operators in Relax.
Adds Codegen tests for Mainline CI.
Also brings in pipeline definitions for Adreno targets.