Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write GH actions to produce docker image #12

Open
DrDub opened this issue Mar 6, 2024 · 7 comments
Open

Write GH actions to produce docker image #12

DrDub opened this issue Mar 6, 2024 · 7 comments
Assignees

Comments

@DrDub
Copy link
Contributor

DrDub commented Mar 6, 2024

The Docker images for UIMACPP should be generated using GitHub Actions.

@tmjoris
Copy link

tmjoris commented Apr 17, 2024

@DrDub I closed the previous PRs and I created a more efficient GH actions file
Screenshot from 2024-04-17 04-37-51

I just wanted to clarify it would be okay if it builds an image each time there's a push and a new PR is created

@DrDub
Copy link
Contributor Author

DrDub commented May 28, 2024

Hi @tmjoris . Thanks for your help and interest in contributing to Apache UIMA!

For the record, this is the past commit where you put together a GH actions file: e825f12

I did look at it, it looks it should do what we want. Now, it contains much reduplication from the Dockerfile. Is there any way to reuse the Dockerfile in there so we don't need to update both places every time something changes?

@DrDub
Copy link
Contributor Author

DrDub commented May 28, 2024

I just wanted to clarify it would be okay if it builds an image each time there's a push and a new PR is created

Very good question. Running tests will make sense on each push and new PR. But building the image might be overkill. On the other hand, this project is low traffic.

I also wonder how many GH Actions credits does the foundation receives as part of its membership.

@reckart
Copy link
Member

reckart commented May 28, 2024

Maybe this helps:

https://infra.apache.org/github-actions-policy.html

tmjoris added a commit to tmjoris/uima-uimacpp that referenced this issue May 28, 2024
tmjoris added a commit to tmjoris/uima-uimacpp that referenced this issue May 28, 2024
@DrDub
Copy link
Contributor Author

DrDub commented May 29, 2024

Maybe this helps:

https://infra.apache.org/github-actions-policy.html

This is fantastic. I tried finding something like this with Google with no avail. Thanks so much!

@tmjoris
Copy link

tmjoris commented May 29, 2024

Hey @DrDub, I realized the first GitHub actions file was inefficient and not compliant with industry standards. So I made some modifications to immensely reduce the time it took to build an image.

I also came to realize that it may be a good idea for a new image to be built each we plan on making a new release which has either new features or significant bug fixes.

However, I've also realized that if we're to publish the image to the GitHub registry I would need to add a login sequence to the actions file, which was not present before. To do that, we would need to follow the standards highlighted in the policy file @reckart sent earlier.

I will update all of you soon on the progress.

@reckart
Copy link
Member

reckart commented May 30, 2024

@tmjoris I am curious what changes you made. Could you open a PR draft so they become visible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants