Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Python annotator from Python extension #8

Open
DrDub opened this issue Mar 6, 2024 · 2 comments
Open

Separate Python annotator from Python extension #8

DrDub opened this issue Mar 6, 2024 · 2 comments
Labels
refactoring Changes to the code while maintaining existing functionality

Comments

@DrDub
Copy link
Contributor

DrDub commented Mar 6, 2024

The Python annotator is a DLL that is both a UIMACPP annotator and a Python module.

That is very clever but causes problems when trying to load multiple version of the UIMACPP annotator or loading them using different multi-threaded configurations.

Instead, the code should build two different DLLs, one for the annotator and another for the Python module.

@DrDub DrDub added the refactoring Changes to the code while maintaining existing functionality label Mar 6, 2024
@tmjoris
Copy link

tmjoris commented Mar 18, 2024

Hello @DrDub I would also like to help solve this issue, any guidance would be highly appreciated

@DrDub
Copy link
Contributor Author

DrDub commented Mar 20, 2024

Hello @tmjoris, mind taking a look at #15 and see if you have luck building the SDK following the instructions? Please comment about that on the PR.

Regarding this issue, it boils down to splitting the file pythonnator.cpp into two file and having the Makefile builds them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Changes to the code while maintaining existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants