Skip to content

Commit ce06db9

Browse files
committed
[YUNIKORN-2065] Fail logs are not reported correctly in some e2e test
1 parent 7b08702 commit ce06db9

File tree

3 files changed

+17
-20
lines changed

3 files changed

+17
-20
lines changed

test/e2e/preemption/preemption_test.go

+5-7
Original file line numberDiff line numberDiff line change
@@ -126,12 +126,6 @@ var _ = ginkgo.AfterSuite(func() {
126126
checks, err := yunikorn.GetFailedHealthChecks()
127127
Ω(err).NotTo(gomega.HaveOccurred())
128128
Ω(checks).To(gomega.Equal(""), checks)
129-
130-
testDescription := ginkgo.CurrentSpecReport()
131-
if testDescription.Failed() {
132-
tests.LogTestClusterInfoWrapper(testDescription.FailureMessage(), []string{ns.Name})
133-
tests.LogYunikornContainer(testDescription.FailureMessage())
134-
}
135129
ginkgo.By("Tearing down namespace: " + ns.Name)
136130
err = kClient.TearDownNamespace(ns.Name)
137131
Ω(err).NotTo(gomega.HaveOccurred())
@@ -553,7 +547,11 @@ var _ = ginkgo.Describe("Preemption", func() {
553547
})
554548

555549
ginkgo.AfterEach(func() {
556-
550+
testDescription := ginkgo.CurrentSpecReport()
551+
if testDescription.Failed() {
552+
tests.LogTestClusterInfoWrapper(testDescription.FailureMessage(), []string{ns.Name})
553+
tests.LogYunikornContainer(testDescription.FailureMessage())
554+
}
557555
// Delete all sleep pods
558556
ginkgo.By("Delete all sleep pods")
559557
err := kClient.DeletePods(ns.Name)

test/e2e/simple_preemptor/simple_preemptor_test.go

+7-7
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,8 @@ var _ = ginkgo.BeforeSuite(func() {
9696
nodesToTaint = append(nodesToTaint, node.Name)
9797
}
9898
}
99+
ginkgo.By("Worker1:" + Worker1)
100+
ginkgo.By("Worker2:" + Worker2)
99101

100102
ginkgo.By("Tainting some nodes..")
101103
err = kClient.TaintNodes(nodesToTaint, taintKey, "value", v1.TaintEffectNoSchedule)
@@ -132,12 +134,6 @@ var _ = ginkgo.AfterSuite(func() {
132134
checks, err := yunikorn.GetFailedHealthChecks()
133135
Ω(err).NotTo(gomega.HaveOccurred())
134136
Ω(checks).To(gomega.Equal(""), checks)
135-
136-
testDescription := ginkgo.CurrentSpecReport()
137-
if testDescription.Failed() {
138-
tests.LogTestClusterInfoWrapper(testDescription.FailureMessage(), []string{ns.Name})
139-
tests.LogYunikornContainer(testDescription.FailureMessage())
140-
}
141137
ginkgo.By("Tearing down namespace: " + ns.Name)
142138
err = kClient.TearDownNamespace(ns.Name)
143139
Ω(err).NotTo(gomega.HaveOccurred())
@@ -219,7 +215,11 @@ var _ = ginkgo.Describe("SimplePreemptor", func() {
219215
})
220216

221217
ginkgo.AfterEach(func() {
222-
218+
testDescription := ginkgo.CurrentSpecReport()
219+
if testDescription.Failed() {
220+
tests.LogTestClusterInfoWrapper(testDescription.FailureMessage(), []string{ns.Name})
221+
tests.LogYunikornContainer(testDescription.FailureMessage())
222+
}
223223
// Delete all sleep pods
224224
ginkgo.By("Delete all sleep pods")
225225
pods, err := kClient.GetPodNamesFromNS(ns.Name)

test/e2e/user_group_limit/user_group_limit_test.go

+5-6
Original file line numberDiff line numberDiff line change
@@ -95,12 +95,6 @@ var _ = ginkgo.AfterSuite(func() {
9595
checks, err := yunikorn.GetFailedHealthChecks()
9696
Ω(err).NotTo(gomega.HaveOccurred())
9797
Ω(checks).To(gomega.Equal(""), checks)
98-
99-
testDescription := ginkgo.CurrentSpecReport()
100-
if testDescription.Failed() {
101-
tests.LogTestClusterInfoWrapper(testDescription.FailureMessage(), []string{ns.Name})
102-
tests.LogYunikornContainer(testDescription.FailureMessage())
103-
}
10498
ginkgo.By("Tearing down namespace: " + ns.Name)
10599
err = kClient.TearDownNamespace(ns.Name)
106100
Ω(err).NotTo(gomega.HaveOccurred())
@@ -368,6 +362,11 @@ var _ = ginkgo.Describe("UserGroupLimit", func() {
368362
})
369363

370364
ginkgo.AfterEach(func() {
365+
testDescription := ginkgo.CurrentSpecReport()
366+
if testDescription.Failed() {
367+
tests.LogTestClusterInfoWrapper(testDescription.FailureMessage(), []string{ns.Name})
368+
tests.LogYunikornContainer(testDescription.FailureMessage())
369+
}
371370
// Delete all sleep pods
372371
ginkgo.By("Delete all sleep pods")
373372
err := kClient.DeletePods(ns.Name)

0 commit comments

Comments
 (0)