[YUNIKORN-1126] Add e2e test for best effort pod #904
Conversation
|
Your change doesn't look like 2714 in your jira link, please update that. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #904 +/- ##
==========================================
+ Coverage 68.04% 68.20% +0.15%
==========================================
Files 70 70
Lines 7558 7558
==========================================
+ Hits 5143 5155 +12
+ Misses 2205 2197 -8
+ Partials 210 206 -4 ☔ View full report in Codecov by Sentry. |
|
|
||
| ginkgo.By("Verify that the pod's QOS class is BestEffort") | ||
| gomega.Ω(bestEffortPod.Status.QOSClass).To(gomega.Equal(v1.PodQOSBestEffort)) | ||
|
|
There was a problem hiding this comment.
assert name and more importantly resource. Resource should be {memory:1}
There was a problem hiding this comment.
For BestEffortPod we are not setting any resources.
- Guaranteed: A pod where each container has the same requests and limits for CPU and memory.
- Burstable: A pod where one or more containers have resource requests set, but no corresponding limits or they differ.
- BestEffort: A pod where neither resource requests nor limits are set.
There was a problem hiding this comment.
Added requested assertion to the test
|
|
||
| ginkgo.By("Verify that the pod's QOS class is not BestEffort") | ||
| gomega.Ω(burstablePod.Status.QOSClass).NotTo(gomega.Equal(v1.PodQOSBestEffort)) | ||
|
|
There was a problem hiding this comment.
assert name and resource. resource should be same as the one passed through config.
There was a problem hiding this comment.
Hi @manirajv06 , Updated the code with the latest code. Added assertion for resource allocation and name for both cases.
craigcondit
changed the title
This PR is for adding end-to-end tests to verify the scheduling of pods with different Quality of Service (QOS) classes in the YuniKorn Kubernetes scheduler. The tests are specifically checking the scheduling of pods with "BestEffort" and "NonBestEffort" (likely "Burstable" or "Guaranteed") QOS classes.
The tests ensure that the pods are correctly scheduled and running and that their QOS classes are as expected. The PR also includes changes to the SleepPodConfig struct and the InitSleepPod function to support setting the QOS class of the pods.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1126
How should this be tested?
Screenshots (if appropriate)
Questions: