From 38d4aff11e00774d07fc7046b53b495ba1838f35 Mon Sep 17 00:00:00 2001 From: Shon Feder Date: Fri, 2 Feb 2024 11:15:12 -0500 Subject: [PATCH] Don't run the port binding tests We know this works thanks to local testing, and while it is a nice UX improvement, it doesn't effect essential functionality enough to complicate our CI configuration to account for it. --- test/tla/cli-integration-tests.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/test/tla/cli-integration-tests.md b/test/tla/cli-integration-tests.md index 892d57ab93..3237804fc2 100644 --- a/test/tla/cli-integration-tests.md +++ b/test/tla/cli-integration-tests.md @@ -4001,7 +4001,12 @@ The Apalache server is running on port 8888. Press Ctrl-C to stop. ### server mode: error is nicely reported when port is already in use +NOTE: These tests are skipped because the would complicate our CI process +more than is warranted by the functionality they test. To enable these tests, +remove the `$MDX skip` annotations. + Start socat in the background to occupy the port, save its pid and wait a second to let binding happen + ```sh $ socat TCP-L:8888,fork,reuseaddr - & echo $! > pid.pid && sleep 1 ``` @@ -4011,6 +4016,7 @@ redirect its output to the file, save its exit code, strip logger prompt and exit with status code of the server + ```sh $ apalache-mc server --port=8888 1>out 2>out; ext=$? && cat out | sed -E 's/E@.*$//' && exit $ext ... @@ -4019,6 +4025,7 @@ Error while starting Apalache server: Failed to bind to address 0.0.0.0/0.0.0.0: ``` Cleanup: kill socat and delete temporary files + ```sh $ cat pid.pid | xargs kill -9 $ rm pid.pid out