Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show changed, final results first? #27

Open
unhammer opened this issue Jan 13, 2023 · 1 comment
Open

show changed, final results first? #27

unhammer opened this issue Jan 13, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@unhammer
Copy link
Member

Here's a typical session of how it looks when I open the web UI after make test complained:

regtest-changes.webm

I try to hide/show unchanged, nothing happens. I try to only show generated, that doesn't seem to help. Then I remember that one of the modes uses postgen, that changes something but I guess I'm still including unchanged things. Another hide/show unchanged. Finally I notice there's a page 2 – and there are the entries I'm after (ie. things that changed in generator).

I feel like something could be done to improve the flow here, but I'm not sure what. I think showing things that actually changed in the last step of the pipeline first in the list would help though (most of the time I don't care about changes in the middle of the pipeline.)

@TinoDidriksen TinoDidriksen added the bug Something isn't working label Oct 25, 2023
@TinoDidriksen
Copy link
Member

Looks like something was lost in the code conversion. The Perl version does show changed results first, then changed, then unchanged.

https://github.com/apertium/apertium-regtest/blob/master/apertium-regtest.py#L671 exists analogously to https://github.com/TinoDidriksen/regtest/blob/main/regtest.pl#L248 but is never filled in or used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants