feat(serializer) Remove the pagination attributes if pagination disabled #7506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaa2000
force-pushed
the
feat-7472-remove-pagination-attributes-if-disabled
branch
2 times, most recently
from
2cbef08 to
f4e5df0
Compare
soyuka
requested changes
Nov 7, 2025
Member
soyuka
left a comment
soyuka
left a comment
There was a problem hiding this comment.
I like this and think it's a bug fix on 4.2.
We should not change the global schema though and instead we should have a collection schema without pagination (the one with pagination would just extend the one without pagination).
Like this we can have operations with and without pagination on the same OpenAPI specification.
aaa2000
force-pushed
the
feat-7472-remove-pagination-attributes-if-disabled
branch
from
f4e5df0 to
3565192
Compare
aaa2000
force-pushed
the
feat-7472-remove-pagination-attributes-if-disabled
branch
3 times, most recently
from
891b950 to
7693f3e
Compare
aaa2000
force-pushed
the
feat-7472-remove-pagination-attributes-if-disabled
branch
from
7693f3e to
d9cf112
Compare
Contributor
Author
|
@soyuka PR on 4.2 branch and I added a collection schema without pagination 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the pagination attributes if pagination is explicitely disabled
Before/after comparison
application/ld+json
application/hal+json
application/vnd.api+json
Another improvement could be to remove the parameters pagination (Enable or disable pagination) and partial (Enable or disable partial pagination)