-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove RRP-specific withdrawal implementation from Airnode v1 #1877
Comments
User's often use |
For example here is a PR clarifying the lack of withdrawal functionality early on due to a Discord discussion: api3dao/old-api3-docs#1107 I use withdrawals in nearly every release test (e.g. #1819, #1839, #1842), and like the functionality's existence so that I don't repeatedly leave testnet funds in various sponsor wallets. That said, having withdrawals external to RRP should also be fine and I envision we can trim a lot from the docs / Airnode repo. |
Thanks for your input. After thinking a bit more, I realize that simply removing the withdrawal functionality from Airnode in favor of something like #1558 (comment) will still be breaking, because people will have set sponsors to be contracts and contracts can't sign messages. They can use ERC1271 but that functionality needs to be built in from the start. So it feels like this is too breaking of a change for v0, but we can consider it for v1 (so I edited the issue title). |
In fact, the only thing to do about this issue at the moment (in the absence of an Airnode v1) is to update this contract to enable #1558 instead. Feel free to re-open the issue if you still think that we should remove withdrawals from v0. |
We should first research if/how often the RRP withdrawal functionality is used on the public chains. Assuming that it's little to none, I propose to remove the withdrawal functionality from Airnode.
Related to #1558
The text was updated successfully, but these errors were encountered: