Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebrand DAO Dashboard - Governance page modals #462

Closed
peterjurco opened this issue Oct 31, 2024 · 4 comments · Fixed by #509
Closed

Rebrand DAO Dashboard - Governance page modals #462

peterjurco opened this issue Oct 31, 2024 · 4 comments · Fixed by #509
Assignees
@Anboias
Labels
dao-dashboard

Comments

@peterjurco
Copy link
Collaborator

peterjurco commented Oct 31, 2024 •
edited
Loading

Update delegation modals on the Governance page based on the new designs

Image

Image

Image
@Anboias Anboias self-assigned this Nov 22, 2024
@peterjurco peterjurco changed the title Rebrand DAO Dashboard - Delegation Rebrand DAO Dashboard - Governance page modals Nov 25, 2024
@Anboias Anboias mentioned this issue Dec 2, 2024
Merged
@Anboias Anboias linked a pull request Dec 2, 2024 that will close this issue
Rebrand Governance page modals #509
Merged
@PrenaamD
Copy link
Collaborator

PrenaamD commented Dec 6, 2024

@Anboias The implementation seems quite different from the design. Is the design outdated?
Implementation
Image

designs
Image

@peterjurco
Copy link
Collaborator Author

@PrenaamD

There was discussion about this and they changed the designs in the meantime. Let's merge this and I will update it as part of the #506. @Anboias are you ok with that?

@Anboias
Copy link
Collaborator

Anboias commented Dec 9, 2024

There was discussion about this and they https://github.com/api3dao/tasks/issues/1535 the designs in the meantime. Let's merge this and I will update it as part of the #506. @Anboias are you ok with that?

Yeah, I agree with this

@PrenaamD
Copy link
Collaborator

PrenaamD commented Dec 9, 2024

Thanks for letting me know. It is fine with me. Please feel free to merge it and close the issue.

@PrenaamD PrenaamD closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anboias Anboias

Labels
dao-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rebrand Governance page modals api3dao/api3-dao-dashboard
3 participants
@Anboias @peterjurco @PrenaamD