You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Quite a lot tests in our code base have pattern like this:
action
sleep(sleep_time)
assert expectation
Such test can be flaky when sleep time is not large enough or will take a lot of time, when sleep time is too big.
It can be advantageous to create a helper function that makes such test more robust in worst case scenario and faster in best case scenario.
Create such abstracted helper function and apply it across the codebase tests.
The text was updated successfully, but these errors were encountered:
Pijukatel
added
t-tooling
Issues with this label are in the ownership of the tooling team.
debt
Code quality improvement or decrease of technical debt.
labels
Dec 16, 2024
Quite a lot tests in our code base have pattern like this:
Such test can be flaky when sleep time is not large enough or will take a lot of time, when sleep time is too big.
It can be advantageous to create a helper function that makes such test more robust in worst case scenario and faster in best case scenario.
where check_period is very low number and check_deadline is larger number.
Non abstracted version of this pattern was used here for example:
https://github.com/apify/crawlee-python/pull/810/files
Create such abstracted helper function and apply it across the codebase tests.
The text was updated successfully, but these errors were encountered: