Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align use_state with JS implementation #856

Open
Pijukatel opened this issue Jan 3, 2025 · 0 comments · May be fixed by #868
Open

Align use_state with JS implementation #856

Pijukatel opened this issue Jan 3, 2025 · 0 comments · May be fixed by #868
Assignees
Labels
enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@Pijukatel
Copy link
Contributor

Pijukatel commented Jan 3, 2025

This is pre-requisite for adaptive crawler : #249

use_state should ensure access to global state without race conditions. Currently there can be race conditions when two parallel handlers try to access same value at the same time. Both can get it from kvs and that results in two separate references. Instead both should always get the same reference. So there should be lock that ensures no race conditions.

use_state in JS implementation has hard-coded key.

@Pijukatel Pijukatel added the enhancement New feature or request. label Jan 3, 2025
@Pijukatel Pijukatel self-assigned this Jan 3, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Jan 3, 2025
@Pijukatel Pijukatel changed the title Handle use_state RequestHandlerRunResult Align use_state with JS implementation Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
1 participant