Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Statistics.liveRetryHistorgram #2733

Open
metalwarrior665 opened this issue Nov 1, 2024 · 0 comments
Open

Create Statistics.liveRetryHistorgram #2733

metalwarrior665 opened this issue Nov 1, 2024 · 0 comments
Labels
feature Issues that represent new features or improvements to existing features. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@metalwarrior665
Copy link
Member

Which package is the feature request for? If unsure which one to select, leave blank

None

Feature

This is a follow up on my bug report with statistics.state.requestsRetries.

The retryHistogram behaves similarly to the bugged retries in that it only updates once the request is handled (succeeds or fails). Unlike with retries, I don't consider this a clear bug because mixing together handled requests and in-progress requests in the histogram could be confusing, especially since new requests that were not even started are coming in.

On the other hand, I still think it is very useful to get the live breakdown of retries. This provides a very good feedback to the developer if the retries are caused by a large number of requests having 1-2 retries or actually few requests hitting a very large retryCount.

I will leave up for discussion if we should figure out how to rework the current retryHistogram or if we should implement a new field e.g..liveRetryHistorgram (bad name). If we go for the new field, I can imagine we would not show the 0 retries case as we get that already from retryHistogram.

See also run on Apify https://console.apify.com/view/runs/cbHWZTetxgehJuK3b

Motivation

See Feature description

Ideal solution or implementation, and any additional constraints

See Feature description

Alternative solutions or implementations

No response

Other context

No response

@metalwarrior665 metalwarrior665 added the feature Issues that represent new features or improvements to existing features. label Nov 1, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issues that represent new features or improvements to existing features. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

1 participant