Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace EnvironmentVariablesKeyProvider with multi_env_vars_key_provider for improved flexibility and maintainability #1087

Open
mxr576 opened this issue Oct 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mxr576
Copy link
Contributor

mxr576 commented Oct 2, 2024

Is your feature request related to a problem?

The current EnvironmentVariablesKeyProvider implementation within the Apigee Edge module is tightly coupled to project-specific decisions made over 7 years ago. It lacks flexibility, such as the ability to configure the environment variable prefix, and could benefit from a modern, maintainable rewrite.

Describe the solution you would like

I propose replacing the existing EnvironmentVariablesKeyProvider in the Apigee Edge module with the multi_env_vars_key_provider that Pronovix released after Apigee Summit 2024. This new module integrates with the Key module and provides a more flexible and configurable solution. Specifically, it allows users to set custom environment variable prefixes, whereas the current solution has APIGEE_EDGE_ hardcoded.

This transition would maintain backward compatibility with the previous solution, ensuring existing configurations continue to work while offering improved maintainability and flexibility for future projects.

Describe alternatives you have considered

An alternative would be updating the current EnvironmentVariablesKeyProvider in the Apigee Edge module to allow for more configuration options. However, given that the multi_env_vars_key_provider is a dedicated solution already designed for such use cases, leveraging this open-source module seems like a more future-proof and standardized approach.

Additional context

The current implementation has aged over 7+ years, and a more flexible solution would better serve users. The multi_env_vars_key_provider module offers a more modern and maintainable approach to managing Apigee credentials across multiple environment variables. This change would not only improve configurability but also align the module with other Key module-based solutions used across Drupal projects.

@mxr576 mxr576 added the enhancement New feature or request label Oct 2, 2024
@mxr576 mxr576 changed the title : Replace EnvironmentVariablesKeyProvider with multi_env_vars_key_provider for improved flexibility and maintainability Replace EnvironmentVariablesKeyProvider with multi_env_vars_key_provider for improved flexibility and maintainability Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant