Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved the validation for monitized enabled org for enabling teams for ApigeeX and edge #940

Merged
merged 13 commits into from
Oct 4, 2023
Merged

Resolved the validation for monitized enabled org for enabling teams for ApigeeX and edge #940

merged 13 commits into from
Oct 4, 2023

Conversation

shishir-intelli
Copy link
Collaborator

Closes #936
Resolved the dead code for validating for Apigee X with Monetization enabled org while enabling Teams module,
also added error message on all Teams related pages if the module is already enabled (In case organisation switched from Edge to X).

@shishir-intelli shishir-intelli added the bug Something isn't working label Sep 25, 2023
@shishir-intelli shishir-intelli added this to the 3.0.3 milestone Sep 25, 2023
mxr576
mxr576 reviewed Oct 3, 2023
View reviewed changes
Copy link
Contributor

@mxr576 mxr576 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

modules/apigee_edge_teams/src/EventSubscriber/ValidateApigeeXTeamEnabledSubscriber.php Outdated Show resolved Hide resolved
modules/apigee_edge_teams/src/EventSubscriber/ValidateApigeeXTeamEnabledSubscriber.php Outdated Show resolved Hide resolved
divya-intelli
divya-intelli approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli merged commit 823cf0d into apigee:3.x Oct 4, 2023
3 checks passed
@shishir-intelli shishir-intelli deleted the issue_936 branch November 30, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxr576 mxr576 mxr576 requested changes

@divya-intelli divya-intelli divya-intelli approved these changes

@giteshk giteshk Awaiting requested review from giteshk

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Drupal-based Development Board
Status: Done
Milestone
3.0.3
Development

Successfully merging this pull request may close these issues.

Apigee X: Monetization vs Teams requirement check is a dead code (?)
4 participants
@shishir-intelli @mxr576 @giteshk @divya-intelli