Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\Drupal::config('system.date')->get('country.default') now has validation and can now be null #482

Open
nlighteneddesign opened this issue May 6, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@nlighteneddesign
Copy link

Problem/Motivation

10.3 introduces some validation [#3437325] so it may no longer be an empty string it is now NULL if it is not set. 10.3 also removes it from the site configuration form so it is more likely to be NULL on new sites [#3439439]

This should only affect new sites installing this module created after 10.3.

Steps to reproduce

Run tests on a fresh install of 10.3

Proposed resolution

Remove dependency on setting like the 2.x branch does.

Remaining tasks

User interface changes

API changes

Data model changes

@nlighteneddesign nlighteneddesign added the bug Something isn't working label May 6, 2024
@kedarkhaire
Copy link
Collaborator

Hi @nlighteneddesign
Thanks for mentioning the details, we will surely look into it.

@kedarkhaire kedarkhaire self-assigned this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants