Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to get to Apollo Client v3 #9546

Open
benasher44 opened this issue Mar 22, 2022 · 1 comment
Open

Trying to get to Apollo Client v3 #9546

benasher44 opened this issue Mar 22, 2022 · 1 comment
Labels
🏓 awaiting-team-response requires input from the apollo team

Comments

@benasher44
Copy link
Contributor

Discussed in https://github.com/apollographql/apollo-client/discussions/9521

Originally posted by benasher44 March 14, 2022
Hello! Our team has been on Apollo Client 2 for some time now, in our main frontend. This frontend is fairly large (have been QA'ing this change for months), and our goal in upgrading is to be able to use HMR available from our build tool (currently CRA but looking to migrate to Vite) — Apollo Client 3 has updates to it that make its caching friendlier for HMR.

Unfortunately, we've tried deploying this upgrade to end users 3 times without success. The first time, we ran into issues related to our own misunderstanding around how the cache-and-network cache policy changed in Apollo Client 3. In attempt 2, we were bit by #9367. In today's attempt 3, things were much more stable, but eventually we realized users were encountering issues related to #6905.

My questions are:

  1. With Stale data on variables change with no-cache fetch policy #6905 and the related issues (in our case, we're using network-only, instead of no-cache), which issue should we be following to know when we can resume our upgrade attempt? (seems there are many that all sort of point to different ones, but all have some form of "useQuery initially gives stale data when changing variables with cache policy )
  2. I also saw Added useQuery frame tests to show that there is an unneeded frame. #9508 (assuming I understand this PR), does this extra frame refer to the single extra render that includes stale data that's mentioned in these related issues? If so, I see that this PR refers to a possible future fix as more of an optimization. To us, this appears to be the final bug preventing us from getting to Apollo Client 3. Does the Apollo Client JS team plan to address it, or is it more of a "nice to have" thing? (linked PR seems not relevant)

Thanks for your help! Understanding where things are will help us plan our own next steps to advance our Apollo/GraphQL usage, internally.

@benasher44
Copy link
Contributor Author

@benjamn as requested, moved this to an issue. Do you all need another repro case, or is the one in #6905 sufficient (only difference being we use network-only as the cache policy)?

@jerelmiller jerelmiller added the 🏓 awaiting-team-response requires input from the apollo team label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏓 awaiting-team-response requires input from the apollo team
Projects
None yet
Development

No branches or pull requests

2 participants