tests: TestCodegenConfigurations projects should fail on warnings #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
|
As expected the SPM-based test codegen configurations are now failing with the warnings being treated as errors. The next commit will remove the warning and they should then pass CI. |
|
..and the test codegen configurations job is now passing, as expected. |
BobaFetters
approved these changes
Dec 13, 2023
AnthonyMDev
approved these changes
Dec 13, 2023
calvincestari
deleted the
tests/fix-testcodegenconfigurations-warnings-as-errors
branch
BobaFetters
pushed a commit
that referenced
this pull request
Dec 13, 2023
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Dec 13, 2023
BobaFetters
pushed a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apollographql/apollo-ios#3301.
I don't know when this stopped working in our test configuration projects but this behaviour is essential to avoid exposing inconvenience warnings to users projects.
I can't find any mention of why the
unsafeFlagsconfiguration no longer works but I do prefer that the flag is now set on the test script command which is more explicit to the workflow we want for the test - reference.I haven't managed to get the behaviour back for Xcode-based projects yet though.