Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rover dev --graph-ref doesn't override federation_version from local supergraph.yaml #2069

Open
michael-watson opened this issue Aug 23, 2024 · 1 comment
Labels
bug 🐞 triage issues and PRs that need to be triaged

Comments

@michael-watson
Copy link
Contributor

Description

When using the --graph-ref option for rover dev, the federation_version used for composition defaults to what is defined in GraphOS and ignores the value defined in your local supergraph.yaml

Steps to reproduce

  1. Start with any new graph in GraphOS, you just need 1 subgraph
  2. Create a new simple schema.graphql file locally:
type Query {
  helloWorld: String
}
  1. Create a supergraph.yaml file locally:
federation_version: =2.10.0-alpha.0
subgraphs:
  test:
    routing_url: http://localhost 
    schema:
      file: schema.graphql
  1. run rover dev command
APOLLO_KEY={API_KEY} rover dev --graph-ref graph@ref --supergraph-config supergraph.yaml
  1. Composition value used in rover dev output will default to the value set in GraphOS and ignored the alpha version

Expected result

rover dev --graph-ref should always use the federation_version defined in the local supergraph config file

Actual result

rover dev --graph-ref ignores the federation_version value defined in the local supergraph config file

Environment

~ % rover info                                                                             
Rover Info:
Version: 0.26.0
Install Location: /Users/michaelwatson/.rover/bin/rover
OS: Mac OS 13.6.8 [64-bit]
Shell: /bin/zsh
@michael-watson michael-watson added bug 🐞 triage issues and PRs that need to be triaged labels Aug 23, 2024
@jackonawalk
Copy link
Contributor

thank you for catching! I'll bring this into the next sprint :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 triage issues and PRs that need to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants