Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rover dev fails to run if windows user name contains a space #2277

Open
luke-pp opened this issue Nov 28, 2024 · 1 comment
Open

Rover dev fails to run if windows user name contains a space #2277

luke-pp opened this issue Nov 28, 2024 · 1 comment
Labels
bug 🐞 triage issues and PRs that need to be triaged

Comments

@luke-pp
Copy link

luke-pp commented Nov 28, 2024

Description

The rover dev command crashes if your windows username contains a space. I believe it is due to some spawned shell processes trying to call an executable path that contains a space, meaning it only grabs the path up till the space.

Steps to reproduce

  1. Create a windows profile with a username that contains a space.
  2. Install rover via iwr 'https://rover.apollo.dev/win/latest' | iex
  3. Run through the retail supergraph example at https://www.apollographql.com/docs/graphos/get-started/guides/quickstart

Expected result

The rover CLI should run the supergraph as normal

Actual result

When running the rover dev command, the rover CLI errors out with an error "C:\Users<Name before space>"
image

Environment

Run rover info and paste the results here

Version: 0.26.2
Install Location: C:\tools\.rover\bin\rover.exe
OS: Windows 10.0.19045 (Windows 10 Pro) [64-bit]
Shell: Unknown

Note: the rover info above is after moving the installed rover binary and updating the PATH environment variable as an attempted workaround, it was initially installed at C:\Users\Jacob Irving\.rover\bin

@luke-pp luke-pp added bug 🐞 triage issues and PRs that need to be triaged labels Nov 28, 2024
@dotdat
Copy link
Contributor

dotdat commented Dec 6, 2024

Thanks for submitting this bug report.

I think this may be an issue with a dependency, but we should have a fix for this particular issue in the next minor release as we move away from using that dependency in this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 triage issues and PRs that need to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants