Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory reference can break if another module improves apos-forms #3

Open
abea opened this issue Jul 3, 2019 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@abea
Copy link
Contributor

abea commented Jul 3, 2019

const confFolder = self.__meta.chain[self.__meta.chain.length - 1].dirname;

If another module improves apostrophe-forms, this will break because it will no longer be at the end of the chain.

@abea abea added the bug Something isn't working label Jul 3, 2019
@abea abea self-assigned this Jul 3, 2019
@boutell
Copy link
Member

boutell commented Jun 18, 2020

Actually the issue is a documentation one, project level lib/modules/apostrophe-forms (not lib/modules/apostrophe-forms-submit-google) is always the end of the chain, but our docs say to use the latter, which is never consulted. See PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants