Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move new fields to beforeConstruct #8

Open
abea opened this issue Jun 12, 2020 · 0 comments
Open

Move new fields to beforeConstruct #8

abea opened this issue Jun 12, 2020 · 0 comments
Assignees
@abea
Labels
bug Something isn't working

Comments

@abea
Copy link
Contributor

abea commented Jun 12, 2020

The apostrophe-forms-submit-google module uses addFields without following the usual beforeConstruct pattern. Since it is an improve of apostrophe-forms, this will break if the project level has any custom schema fields for apostrophe-forms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abea abea

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moves added schema to beforeConstruct apostrophecms/apostrophe-forms-submit-google
1 participant
@abea