Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow signing of packages #17

Open
mrsimonemms opened this issue Sep 4, 2024 · 0 comments
Open

Allow signing of packages #17

mrsimonemms opened this issue Sep 4, 2024 · 0 comments

Comments

@mrsimonemms
Copy link

mrsimonemms commented Sep 4, 2024

Is your feature request related to a problem? Please describe.
I've been looking at using this library to publish signed OCI charts. The Helm docs require passing additional arguments to the helm package command to achieve this

helm package --sign --key 'John Smith' --keyring path/to/keyring.secret mychart

Describe the solution you'd like
There are two ways of achieving this to my mind:

  1. add some arguments to the input - I think it'll be something like sign, key, passphrase and keyring with sign defaulting to false (passphrase would emulate passphrase-file - to read from stdin)
  2. add ability to add any argument to the package command. Whilst I'm not normally a fan of this approach, it might be useful to allow any argument to be passed in for future usage?

In both cases, the setting up of the key/keyring will be external to this. The PR should also include updating the README to include a signing example

Describe alternatives you've considered
Create my own Helm publish Action

Additional context
Happy to create a PR if this would be acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant