Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs #4

Open
manojdcoder opened this issue Mar 23, 2016 · 10 comments
Open

Updated docs #4

manojdcoder opened this issue Mar 23, 2016 · 10 comments

Comments

@manojdcoder
Copy link

Where shall we download the updated docs for offline usage? So we can just update the app/docs folder ourself as on required rather waiting for a release here?

@FokkeZB
Copy link
Contributor

FokkeZB commented Mar 30, 2016

Unfortunately atm our docs CI builds are broken so I can't make a new version. We're looking into integrating builds of this app in docs CI.

@manojdcoder
Copy link
Author

Thanks, offline docs will be really useful. Looking forward for the update.

@FokkeZB
Copy link
Contributor

FokkeZB commented Apr 11, 2016

The CI builds have been fixed, but I've (lots of) issues getting the app to work again. I needed to upgrade it to current versions of electron but there were a lot of breaking changes. I'm sorry but atm I don't have time to work on this (experimental) app.

I have pushed what I have so far to a separate branch, so if you have time to get it working again, that would be great!

https://github.com/appcelerator-developer-relations/appc-docs-desktop/tree/develop

@manojdcoder
Copy link
Author

Can you please paste the link to download the offline docs?

I followed the steps here to build the docs myself. But the final output uses ExtJS theme instead of the Appcelerator one.

doc

@FokkeZB
Copy link
Contributor

FokkeZB commented Apr 17, 2016

@mano-mykingdom you can get the list with CI build zips here: http://builds.appcelerator.com.s3.amazonaws.com/mobile/docs/index.json

If you get it to work again and can do a PR that would be great!

@manojdcoder
Copy link
Author

manojdcoder commented Apr 22, 2016

@FokkeZB The latest doc that downloaded from the link you shared, doesn't seem working perfectly.

  1. Landing page style sheet is missing for Platform
  2. Landing page itself missing for ArrowDB
  3. ArrowDB search is broken
  4. Dropdown for switching from Platform to ArrowDB is broken
  5. Theme is outdated (Comparing with live latest docs)

PR for electron fixes - #5

@FokkeZB
Copy link
Contributor

FokkeZB commented May 2, 2016

Thanks for #5! I've merged it and also added the build dir to the git since it would fail without. But even with that when I run node build it now gets me builds in dist, but when I start the Mac app (which btw has the default Electron icon) is blank. I believe that was where I last gave up. Did you get any further?

@manojdcoder
Copy link
Author

manojdcoder commented May 2, 2016

It worked just fine for me, either with default electron app or after node build

appc-docs

default electron debug

If you share the keys to sign the mac build, I may able to complete the build on my machine. As of now it fails with the logs below.

Copying app to tmp/app..
Packaging..
Packaging app for platform linux ia32 using electron v0.37.7
Packaging app for platform win32 ia32 using electron v0.37.7
Packaging app for platform darwin x64 using electron v0.37.7
Packaging app for platform linux x64 using electron v0.37.7
Packaging app for platform mas x64 using electron v0.37.7
WARNING: signing is required for mas builds. Provide the osx-sign option, or manually sign the app later.
Packaging app for platform win32 x64 using electron v0.37.7
Compressing linux-ia32..
Compressing linux-x64..
Building darwin-x64..
Rebuilding app dependencies for arch x64 to /Users/manojkumar/Backup/Worksapce/appc-docs-desktop/app
Packaging app for platform darwin x64 using electron v0.37.7
App is not signed: CSC_LINK or CSC_NAME are not specified

Reminder: As I mentioned in my previous comment, there are few issues (but not source stoppers) with latest docs build.

@FokkeZB
Copy link
Contributor

FokkeZB commented May 3, 2016

Ah, now I see... appc-docs-desktop/tmp/builds/AppC-Docs-darwin-x64 is there with the right icon and working, just appc-docs-desktop/dist/AppC-Docs-darwin-x64 is blank and has the Electron logo.

Probably because of that signing problem. Previous versions of Electron build didn't require this so I've never set these keys up. LMC

@FokkeZB
Copy link
Contributor

FokkeZB commented May 3, 2016

Mmm, I got signing working but the distribution version is still blank and with default icon. I'm afraid I don't have more time to invest today. Hopefully later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants