diff --git a/ranger-discovery-bundle/src/main/java/io/appform/ranger/discovery/bundle/id/CollisionChecker.java b/ranger-discovery-bundle/src/main/java/io/appform/ranger/discovery/bundle/id/CollisionChecker.java index 4099e057..9ea978f4 100644 --- a/ranger-discovery-bundle/src/main/java/io/appform/ranger/discovery/bundle/id/CollisionChecker.java +++ b/ranger-discovery-bundle/src/main/java/io/appform/ranger/discovery/bundle/id/CollisionChecker.java @@ -48,11 +48,7 @@ public boolean check(long curTimeMs, dataLock.lock(); try { long currentTime = resolution.convert(curTimeMs, TimeUnit.MILLISECONDS); - if (currentTime < lastResolvedTime) { - log.error("Clock has moved backwards. Rejecting requests until current time {} reaches {}", currentTime, - lastResolvedTime); - return false; - } + // TODO: Handle case when (currentTime < lastResolvedTime) as it can result in Duplicate IDs if (lastResolvedTime != currentTime) { lastResolvedTime = currentTime; bitSet.clear(); diff --git a/ranger-discovery-bundle/src/test/java/io/appform/ranger/discovery/bundle/id/CollisionCheckerTest.java b/ranger-discovery-bundle/src/test/java/io/appform/ranger/discovery/bundle/id/CollisionCheckerTest.java index d0879561..3f29c2e7 100644 --- a/ranger-discovery-bundle/src/test/java/io/appform/ranger/discovery/bundle/id/CollisionCheckerTest.java +++ b/ranger-discovery-bundle/src/test/java/io/appform/ranger/discovery/bundle/id/CollisionCheckerTest.java @@ -37,13 +37,4 @@ void testCheck() { Assertions.assertFalse(collisionChecker.check(101, i)); }); } - - @Test - void testCheckGoingBackInTime() { - CollisionChecker collisionChecker = new CollisionChecker(); - Assertions.assertTrue(collisionChecker.check(100, 1)); - Assertions.assertFalse(collisionChecker.check(90, 1)); - Assertions.assertFalse(collisionChecker.check(100, 1)); - Assertions.assertTrue(collisionChecker.check(101, 1)); - } } \ No newline at end of file