Adopt typed throws across 'BinaryParsing' #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To accommodate both user and library errors on parser function-taking functions (like Range.init(parsingStartAndEnd:parser:)), this adds a 'typealias ThrownParsingError' that aliases 'ParsingError' in embedded mode and 'any Error' elsewhere. This has the benefit of keeping the simplicity of untyped errors in non-embedded code, but means that adopting code can't choose to use explicitly typed errors when in non-embedded mode.
| @@ -107,3 +107,9 @@ extension ParsingError: CustomStringConvertible { | |||
| } | |||
| } | |||
| #endif | |||
|
|
|||
| #if !$Embedded | |||
There was a problem hiding this comment.
I think these type aliases probably merit a doc comment.
stephentyrone
approved these changes
Jun 10, 2025
|
Is it possible to surface typed throws using a package trait instead of checking for the embedded mode? |
|
by the way I think |
|
For |
|
I mean I agree, but I was under the impression Doug wanted the |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To accommodate both user and library errors on parser function-taking functions (like
Range.init(parsingStartAndEnd:parser:)), this adds atypealias ThrownParsingErrorthat aliasesParsingErrorin embedded mode andany Errorelsewhere. This has the benefit of keeping the simplicity of untyped errors in non-embedded code, but means that adopting code can't choose to use explicitly typed errors when in non-embedded mode.Addresses #3.