Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multipart generated enum case naming is inconsistent (other vs additionalProperties) #598

Open
czechboy0 opened this issue Jul 22, 2024 · 3 comments
Open

Multipart generated enum case naming is inconsistent (other vs additionalProperties) #598

czechboy0 opened this issue Jul 22, 2024 · 3 comments
Labels
area/generator Affects: plugin, CLI, config file. kind/bug Feature doesn't work as expected.
Milestone
Post-1.0

Comments

@czechboy0
Copy link
Contributor

Description

The generated code doesn't follow the multipart SOAR proposal, see details in #596

Reproduction

See the example in #596.

Package version(s)

On main.

Expected behavior

Consistent behavior that matches the proposal.

Environment

Xcode 16 Beta.

Additional information

No response
@czechboy0 czechboy0 added kind/bug Feature doesn't work as expected. status/triage Collecting information required to triage the issue. area/generator Affects: plugin, CLI, config file. and removed status/triage Collecting information required to triage the issue. labels Jul 22, 2024
@czechboy0
Copy link
Contributor Author

Just fixing this would lead to a breaking change, so we'll need a feature flag here.

@czechboy0 czechboy0 added this to the Post-1.0 milestone Jul 22, 2024
@czechboy0 czechboy0 mentioned this issue Jul 22, 2024
Closed
@simonjbeaumont
Copy link
Contributor

Can we use a computed property or indirect enum case for the backwards compatibility?

@czechboy0
Copy link
Contributor Author

For constructing the enum, possibly (including a typealias as well, for any potential inlined type), but consuming the enum, I don't think we can add a case without breaking people's code. But it's an idea we should explore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/generator Affects: plugin, CLI, config file. kind/bug Feature doesn't work as expected.
Projects
None yet
Milestone
Post-1.0
Development

No branches or pull requests
2 participants
@simonjbeaumont @czechboy0