fix warnings (#34)

Don't run symbolizer's potentially blocking `start`/`shutdown` methods
on the Swift Concurrency thread pool.

Co-authored-by: Johannes Weiss <[email protected]>

Author: weissi

Scripts/smoke-test.sh

@@ -16,6 +16,7 @@ socket_path="$tmpdir/swipr.sock"
 PROFILE_RECORDER_SERVER_URL=unix://"$socket_path" \
     "$tmpdir"/build/release/swipr-mini-demo \
     --blocking --burn-cpu --array-appends \
+    --tsp true \
     --output "$output"/samples.swipr \
     --iterations 1000 \
     --profiling-server &

Sources/ProfileRecorderSampleConversion/Sampler+Conversion.swift

@@ -13,6 +13,7 @@
 //===----------------------------------------------------------------------===//
 
 import ProfileRecorder
+import ProfileRecorderHelpers
 import Logging
 import NIO
 import _NIOFileSystem
@@ -119,17 +120,22 @@ extension ProfileRecorderSampler {
         _ body: (String) async throws -> R
     ) async throws -> R {
         let symbolizer = ProfileRecorderSampler._makeDefaultSymbolizer()
-        try symbolizer.start()
-        defer {
-            try! symbolizer.shutdown()
+        try await NIOThreadPool.singleton.runIfActive {
+            try symbolizer.start()
+        }
+        return try await asyncDo {
+            return try await self._withSamples(
+                sampleCount: sampleCount,
+                timeBetweenSamples: timeBetweenSamples,
+                format: .perfSymbolized,
+                symbolizer: symbolizer,
+                logger: logger,
+                body
+            )
+        } finally: { _ in
+            try await NIOThreadPool.singleton.runIfActive {
+                try symbolizer.shutdown()
+            }
         }
-        return try await self._withSamples(
-            sampleCount: sampleCount,
-            timeBetweenSamples: timeBetweenSamples,
-            format: .perfSymbolized,
-            symbolizer: symbolizer,
-            logger: logger,
-            body
-        )
     }
 }

Sources/ProfileRecorderServer/Server.swift

@@ -319,9 +319,8 @@ public struct ProfileRecorderServer: Sendable {
         }
 
         let symbolizer = ProfileRecorderSampler._makeDefaultSymbolizer()
-        try symbolizer.start()
-        defer {
-            try! symbolizer.shutdown()
+        try await NIOThreadPool.singleton.runIfActive {
+            try symbolizer.start()
         }
 
         return try await asyncDo {
@@ -399,6 +398,9 @@ public struct ProfileRecorderServer: Sendable {
             if let udsPath = configuration.unixDomainSocketPath {
                 _ = try? await FileSystem.shared.removeItem(at: FilePath(udsPath))
             }
+            try await NIOThreadPool.singleton.runIfActive {
+                try symbolizer.shutdown()
+            }
         }
     }