Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

djangular's karma support should be updated, and can be enhanced #21

Open
robdennis opened this issue Mar 18, 2014 · 1 comment
Open

Comments

@robdennis
Copy link

Djangular supports developers writing karma using these two management commands:

  • makeangularsite creates karma config file templates that handle the djangular app paths
  • testjs will shell out to karma and run the appropriate config file

the first is in need of an update:
as karma is on 0.12 and djangular writes out a file that's no longer compatible (I believe we're writing out a 0.8-style file, but there was backwards incompatible change in 0.9 or 0.10)

the second could use some enhancements:

  • the management command assumes that karma exists on the path (which isn't typical when not installing using npm -g)
  • there's no way to pass additional command line arguments to the karma invocation, which is useful for having jenkins run against PhantomJS and then letting developers override this at their desktops to run Firefox/Chrome
  • running testjs assume's that you have a very particular working directory so it can find an app's config files. It would be convenient let testjs work no matter your working directory.
@LiamK
Copy link

LiamK commented Nov 6, 2014

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants