Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version override: Use edx-sga 0.22.0 via appsembler.txt reqs #1368

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Fix version override: Use edx-sga 0.22.0 via appsembler.txt reqs #1368

merged 1 commit into from
Aug 29, 2023
+1 −1

Conversation

bryanlandia
Copy link

@bryanlandia bryanlandia commented Aug 29, 2023 •
edited
Loading

Change description

edx-sga in EDXAPP_EXTRA_REQUIREMENTS via server-vars.yml wasn't overriding the one defined in requirements/edx/appsembler.txt. Define it directly in our pip requirements.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@github-actions

This comment has been minimized.

Sign in to view
@bryanlandia bryanlandia force-pushed the bugfix/requirements-use-patched-edx-sga-0.22.0 branch from eacb6cc to edadd6d Compare August 29, 2023 22:32
@github-actions
Copy link

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 299
Current conflicts 299
Summary Good work! No added conflicts.
Comparing with master
Benchmark conflicts with main 312
Current conflicts 312
Summary Good work! No added conflicts.

@bryanlandia bryanlandia marked this pull request as ready for review August 29, 2023 22:36
@bryanlandia bryanlandia merged commit 7a8ccab into main Aug 29, 2023
11 checks passed
@bryanlandia bryanlandia deleted the bugfix/requirements-use-patched-edx-sga-0.22.0 branch August 29, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirtds amirtds amirtds approved these changes

@xscrio xscrio Awaiting requested review from xscrio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanlandia @amirtds