Use resource IDs instead of names in role definitions to refer to roles #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Review Status
Working Directory: |
Pull Request Review Status
Working Directory: |
KashifSaadat
approved these changes
Oct 28, 2024
KashifSaadat
added a commit
that referenced
this pull request
Oct 29, 2024
* Use resource IDs instead of names in role definitions to refer to roles (#71) * chore: set role definitions ids instead of names * chore: update docs to be inline with the new version used by gh action --------- Co-authored-by: Adam Smith <[email protected]> * feat: bringing the repository inline with the template (#72) * feat: bringing the repository inline with the template * chore: adding the ignore back on the tfavrs * fix: removing the unused provider, as per linting issue * chore: changing the name of the file for consistency with other modules * chore: removing the old file * feat: wayfinder v2.9.6 --------- Co-authored-by: Adam Smith <[email protected]> Co-authored-by: Adam Smith <[email protected]> Co-authored-by: Rohith Jayawardene <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/role_assignment#role_definition_name the role_definition_name parameter should only be used for builtin roles
This likely fixes the issues that required a sleep between role creation and assignment