Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support updating package.json version #118

Open
P4sca1 opened this issue Dec 1, 2024 · 1 comment
Open

Support updating package.json version #118

P4sca1 opened this issue Dec 1, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@P4sca1
Copy link

P4sca1 commented Dec 1, 2024

Hey there,

thank you for open-sourcing this project. It is very useful to me.
Would it be possible to add support for updating package.json files? Using markers does not work, because comments are invalid in JSON and the v prefix needs to be removed from the version.

@apricote apricote added the enhancement New feature or request label Dec 7, 2024
@apricote
Copy link
Owner

apricote commented Dec 7, 2024

Sounds like a good feature. The comments are quite limited, but all that I needed to get it working in the majority of my current active projects.

I already tried to make the "updaters" pluggable, so all it would need is a new updater and some way for the user to configure it. Could even start with a hardcoded /package.json. Here is how release-please makes this configurable.


For now I am still working on the features that I personally need, so I will not get to this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants