Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cp][aptos-release-v1.23] Bumping up the max transaction execution gas limit for gov proposals #15394

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport

This will backport the following commits from main to aptos-release-v1.23:

Questions ?

Please refer to the Backport tool documentation

Copy link

trunk-io bot commented Nov 25, 2024

⏱️ 1h 27m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 28m 🟩
rust-unit-tests 22m 🟩
rust-move-tests 9m 🟩
rust-doc-tests 5m 🟩
execution-performance / test-target-determinator 5m 🟩
test-target-determinator 5m 🟩
check 4m 🟩
check-dynamic-deps 3m 🟩🟩
rust-cargo-deny 2m 🟩
fetch-last-released-docker-image-tag 2m 🟩
semgrep/ci 55s 🟩🟩
Backport PR 41s 🟥🟩
general-lints 25s 🟩
file_change_determinator 13s 🟩
file_change_determinator 10s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 28m 17m +64%

settingsfeedbackdocs ⋅ learn more about trunk.io

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor Author

✅ Forge suite realistic_env_max_load success on 2d3d5717cefd4b1663be8ab3ab592bc706e3398b

two traffics test: inner traffic : committed: 14074.62 txn/s, latency: 2823.48 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5351480
two traffics test : committed: 99.96 txn/s, latency: 1870.99 ms, (p50: 1400 ms, p70: 1400, p90: 1600 ms, p99: 13500 ms), latency samples: 1800
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.675, avg: 1.691", "ConsensusProposalToOrdered: max: 0.320, avg: 0.293", "ConsensusOrderedToCommit: max: 0.376, avg: 0.363", "ConsensusProposalToCommit: max: 0.665, avg: 0.656"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.18s no progress at version 22748 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.76s no progress at version 2149537 (avg 15.76s) [limit 16].
Test Ok

Copy link
Contributor Author

✅ Forge suite framework_upgrade success on afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 2d3d5717cefd4b1663be8ab3ab592bc706e3398b

Compatibility test results for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 2d3d5717cefd4b1663be8ab3ab592bc706e3398b (PR)
Upgrade the nodes to version: 2d3d5717cefd4b1663be8ab3ab592bc706e3398b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1278.40 txn/s, submitted: 1282.17 txn/s, failed submission: 3.78 txn/s, expired: 3.78 txn/s, latency: 2365.95 ms, (p50: 2100 ms, p70: 2500, p90: 3600 ms, p99: 5100 ms), latency samples: 115140
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1403.49 txn/s, submitted: 1404.39 txn/s, failed submission: 0.91 txn/s, expired: 0.91 txn/s, latency: 2119.88 ms, (p50: 2000 ms, p70: 2100, p90: 3300 ms, p99: 4400 ms), latency samples: 124020
5. check swarm health
Compatibility test for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 2d3d5717cefd4b1663be8ab3ab592bc706e3398b passed
Upgrade the remaining nodes to version: 2d3d5717cefd4b1663be8ab3ab592bc706e3398b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1315.61 txn/s, submitted: 1320.24 txn/s, failed submission: 4.62 txn/s, expired: 4.62 txn/s, latency: 2283.39 ms, (p50: 2100 ms, p70: 2400, p90: 3400 ms, p99: 4200 ms), latency samples: 119540
Test Ok

Copy link
Contributor Author

✅ Forge suite compat success on afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 2d3d5717cefd4b1663be8ab3ab592bc706e3398b

Compatibility test results for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 2d3d5717cefd4b1663be8ab3ab592bc706e3398b (PR)
1. Check liveness of validators at old version: afa8d75c467820b7d96bbe13ab0d011c12f8b3a3
compatibility::simple-validator-upgrade::liveness-check : committed: 14704.03 txn/s, latency: 2325.88 ms, (p50: 2100 ms, p70: 2100, p90: 2300 ms, p99: 7600 ms), latency samples: 517160
2. Upgrading first Validator to new version: 2d3d5717cefd4b1663be8ab3ab592bc706e3398b
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7238.15 txn/s, latency: 3859.14 ms, (p50: 4200 ms, p70: 4300, p90: 5100 ms, p99: 5100 ms), latency samples: 146380
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7764.05 txn/s, latency: 4108.02 ms, (p50: 4200 ms, p70: 4300, p90: 6300 ms, p99: 6500 ms), latency samples: 257360
3. Upgrading rest of first batch to new version: 2d3d5717cefd4b1663be8ab3ab592bc706e3398b
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7881.03 txn/s, latency: 3647.38 ms, (p50: 4100 ms, p70: 4300, p90: 4400 ms, p99: 4500 ms), latency samples: 145400
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7188.39 txn/s, latency: 4500.84 ms, (p50: 4400 ms, p70: 4500, p90: 7000 ms, p99: 7200 ms), latency samples: 263140
4. upgrading second batch to new version: 2d3d5717cefd4b1663be8ab3ab592bc706e3398b
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10815.82 txn/s, latency: 2473.64 ms, (p50: 2400 ms, p70: 2800, p90: 3900 ms, p99: 4100 ms), latency samples: 187020
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11310.17 txn/s, latency: 2777.24 ms, (p50: 2400 ms, p70: 2700, p90: 5200 ms, p99: 7100 ms), latency samples: 361400
5. check swarm health
Compatibility test for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 2d3d5717cefd4b1663be8ab3ab592bc706e3398b passed
Test Ok

@sherry-x sherry-x merged commit 565d4e0 into aptos-release-v1.23 Nov 29, 2024
77 of 97 checks passed
@sherry-x sherry-x deleted the backport/aptos-release-v1.23/pr-15352 branch November 29, 2024 00:50
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
aptos-release-v1.24

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants