[API] Handle pre-commit race condition.

[JoshLind]

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Move Compiler
• Other (specify)

Checklist

• I have read and followed the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I identified and added all stakeholders and component owners affected by this change as reviewers
• I tested both happy and unhappy path of the functionality
• I have made corresponding changes to the documentation

[trunk-io]

⏱️ 9h 5m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	3h 9m	🟩 🟩 🟩 🟩 🟩 (+5 more)
execution-performance / test-target-determinator	45m	🟩 🟩 🟩 🟩 🟩 (+5 more)
test-target-determinator	33m	⬜ ⬜ 🟩 🟩 🟩 (+5 more)
check	31m	⬜ ⬜ 🟩 🟩 🟩 (+5 more)
rust-unit-tests	24m	🟩
rust-unit-tests	23m	🟩
rust-unit-tests	22m	🟩
rust-cargo-deny	17m	⬜ ⬜ 🟩 🟩 🟩 (+5 more)
check-dynamic-deps	16m	🟩 🟩 🟩 🟩 🟩 (+6 more)
fetch-last-released-docker-image-tag	15m	⬜ 🟩 🟩 🟩 🟩 (+5 more)
rust-unit-tests	15m	⬜
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[trunk-io]

     

View Full Report ↗︎ ⋅ Docs

[github-actions]

✅ Forge suite realistic_env_max_load success on 64f511574356ccc26f5ae0d789e57ad7a9dc1a38

two traffics test: inner traffic : committed: 14050.65 txn/s, latency: 2828.65 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5342380
two traffics test : committed: 100.04 txn/s, latency: 2053.26 ms, (p50: 1400 ms, p70: 1500, p90: 2100 ms, p99: 17600 ms), latency samples: 1800
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.312, avg: 1.516", "ConsensusProposalToOrdered: max: 0.318, avg: 0.292", "ConsensusOrderedToCommit: max: 0.383, avg: 0.370", "ConsensusProposalToCommit: max: 0.674, avg: 0.663"]
Max non-epoch-change gap was: 1 rounds at version 48032 (avg 0.00) [limit 4], 1.84s no progress at version 48032 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.80s no progress at version 2790436 (avg 15.80s) [limit 16].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on 565d4e06702fc9f7a6a9c7741e9533e10c3235ef ==> 64f511574356ccc26f5ae0d789e57ad7a9dc1a38

Compatibility test results for 565d4e06702fc9f7a6a9c7741e9533e10c3235ef ==> 64f511574356ccc26f5ae0d789e57ad7a9dc1a38 (PR)
1. Check liveness of validators at old version: 565d4e06702fc9f7a6a9c7741e9533e10c3235ef
compatibility::simple-validator-upgrade::liveness-check : committed: 16686.13 txn/s, latency: 2016.01 ms, (p50: 2000 ms, p70: 2100, p90: 2500 ms, p99: 3000 ms), latency samples: 544940
2. Upgrading first Validator to new version: 64f511574356ccc26f5ae0d789e57ad7a9dc1a38
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7809.28 txn/s, latency: 3540.40 ms, (p50: 3500 ms, p70: 4000, p90: 4900 ms, p99: 5300 ms), latency samples: 144680
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7829.94 txn/s, latency: 4104.90 ms, (p50: 4200 ms, p70: 4400, p90: 6000 ms, p99: 6200 ms), latency samples: 255260
3. Upgrading rest of first batch to new version: 64f511574356ccc26f5ae0d789e57ad7a9dc1a38
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7922.45 txn/s, latency: 3579.36 ms, (p50: 3900 ms, p70: 4100, p90: 4300 ms, p99: 4400 ms), latency samples: 146740
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7824.18 txn/s, latency: 4083.17 ms, (p50: 4200 ms, p70: 4400, p90: 5900 ms, p99: 6200 ms), latency samples: 261000
4. upgrading second batch to new version: 64f511574356ccc26f5ae0d789e57ad7a9dc1a38
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10160.69 txn/s, latency: 2623.59 ms, (p50: 2400 ms, p70: 3100, p90: 4300 ms, p99: 4600 ms), latency samples: 177740
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9948.03 txn/s, latency: 3063.64 ms, (p50: 2500 ms, p70: 3300, p90: 5900 ms, p99: 8100 ms), latency samples: 333420
5. check swarm health
Compatibility test for 565d4e06702fc9f7a6a9c7741e9533e10c3235ef ==> 64f511574356ccc26f5ae0d789e57ad7a9dc1a38 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking