-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Windows #850
Comments
I didn't know this function. |
Install Path (AQUA_ROOT_DIR)XDG Base Directory doesn't match Windows. https://aquaproj.github.io/docs/reference/config#environment-variables We have to decide the default value of AQUA_ROOT_DIR on Windows. |
If we support windows, almost all of supported_if: GOARCH == "amd64" or GOOS == "darwin" |
We can use adrg/xdg to handle XDG Base Directory Specification even on Windows and simplify logics.
|
Hmm...
|
Oh, it's interesting. thank you. |
I got a Windows Server by Amazon Workspaces. Expectedly, it failed to build aqua on Windows. $ go build -o dist/aqua ./cmd/aqua
// ...
pkg\exec\exec.go:36:14: undefined: unix.Exec Lines 35 to 37 in a7b5c0f
https://pkg.go.dev/golang.org/x/sys/unix#Exec |
#850 (comment) was solved by #852 |
aqua-proxy for Windows is also needed. https://github.com/aquaproj/aqua-proxy
|
Check List
|
#853 It works. $ go get github.com/suzuki-shunsuke/go-findconfig@09feb0c9f81fc9a379ddcd1432d45958581e011e |
ktr0731/go-fuzzyfinder#2 (comment) I've confirmed that Updated. ktr0731/go-fuzzyfinder#2 (comment) |
Fix Standard RegistryInstall all packages on Windows$ aqua -c aqua-all.yaml i |
💡 Allow aqua to create symbolic linksaqua creates symbolic links, so you have to allow aqua to create symbolic links. In Git BashRun Git Bash as administrator and set the environment variable. export MSYS=winsymlinks:nativestrict |
Maybe aqua should set the suffix |
|
gnu vs msvcI'm not familiar with Windows and Rust. https://rust-lang.github.io/rustup/installation/windows.html
Hmm... |
aqua depends on the environment variable https://aquaproj.github.io/docs/reference/config/#environment-variables
|
Give up supporting tools written in shell scripts on Windows for nowI'll exclude windows by
|
Feature Overview
Currently, aqua doesn't support Windows.
It is desirable for aqua to support Windows.
I don't have Windows, so I'm not familiar with Windows.
And it is a little difficult to verify aqua on Windows.
There are differences between Windows and Linux, so we have to solve some problems.
aqua/pkg/controller/which/lookpath.go
Lines 13 to 29 in a7b5c0f
aqua/pkg/exec/exec.go
Line 11 in a7b5c0f
We also have to fix aqua-registry to support Windows.
Why is the feature needed?
Windows is most popular OS, so the Windows support may make aqua more popular.
Does the feature include Breaking Changes?
Probably no, but we have to investigate it.
Example Code
Nothing.
The text was updated successfully, but these errors were encountered: