Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for the special group system:masters #86

Open
raesene opened this issue Mar 25, 2021 · 0 comments
Open

Add handling for the special group system:masters #86

raesene opened this issue Mar 25, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@raesene
Copy link

raesene commented Mar 25, 2021

What would you like to be added

The system:masters group in Kubernetes is special in that it always has full permissions to a cluster, even if there are no clusterrolebindings for it. There's a reference in the API server source code here

At the moment kubectl-who-can doesn't account for that, so will incorrectly not report members of system:masters as having all rights, if there are no clusterrolebindings mentioning them.

The correct solution is likely to just report true where the principal is an authenticated member of that group.

Why is this needed

Without this, incorrect conclusions might be reached about who has access to what :)

@raesene raesene added the enhancement New feature or request label Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant