Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beforeEngage happening every assist loop #17

Open
towbes opened this issue Apr 5, 2024 · 4 comments
Open

beforeEngage happening every assist loop #17

towbes opened this issue Apr 5, 2024 · 4 comments

Comments

@towbes
Copy link
Contributor

towbes commented Apr 5, 2024

My rogues were constantly spamming hide when I had "Evade" on , and I added a logger line to before engage if statement. Looks like that's getting called every loop

image

function assist.doAssist(reset_timers, returnAfterAnnounce)
    local assistMobID = assist.getAssistSpawnIncludeManual()
    if assistMobID == 0 then return false end
    if assist.checkMATargetSwitch(assistMobID) then
        if assist.targetAssistSpawn(assistMobID) then
            assist.setAndAnnounceNewAssistTarget(assistMobID, reset_timers)
            if returnAfterAnnounce then return true end
        end
    end
    if state.assistMobID == 0 then return false end
    if not state.medding or not config.get('MEDCOMBAT') then
        if class:isAbilityEnabled('USEMELEE') then
            assist.getCombatPosition()
            if state.assistMobID and state.assistMobID > 0 and not mq.TLO.Me.Combat() and class.beforeEngage then
                logger.debug(logger.flags.routines.assist, "beforeengage")
                class:beforeEngage()
            end
            assist.engage()
        else
            assist.checkLOS()
        end
    end
    assist.sendPet()
    return true
end
@aquietone
Copy link
Owner

I'm not seeing this one. added the same print and i only see if when entering combat or if i manually turn off auto attack while fighting.

@towbes
Copy link
Contributor Author

towbes commented Apr 13, 2024

Forgot to circle back to this because i dropped my rogues. Will try to reproduce this again with them

@towbes
Copy link
Contributor Author

towbes commented Apr 15, 2024

Also cannot reproduce this using latest versions so this must have been do to a custom change i had when messing around with evade.

@towbes towbes closed this as completed Apr 15, 2024
@towbes
Copy link
Contributor Author

towbes commented Apr 15, 2024

Edited out my comment. I think this is still happening with just base version of assist.lua. The behavior seems to change as evade is toggled on and off.

I'm using a training dummy, and have to manually press the attack button the first time to start the engage which might be throwing something off...
image

@towbes towbes reopened this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants