feat: remove the external url icon form the Link component

aradzie · Nov 11, 2024 · 089ed99 · 089ed99
1 parent a9c1dba
commit 089ed99
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 20 deletions.
diff --git a/packages/keybr-widget/assets/open-in-new.svg b/packages/keybr-widget/assets/open-in-new.svg
diff --git a/packages/keybr-widget/lib/components/text/Link.module.less b/packages/keybr-widget/lib/components/text/Link.module.less
@@ -1,15 +1,3 @@
 .root {
   /* Empty. */
 }
-
-.external:dir(ltr) {
-  padding-inline-end: 1.3rem;
-  background: url(../../../assets/open-in-new.svg) no-repeat center right;
-  background-size: 1rem;
-}
-
-.external:dir(rtl) {
-  padding-inline-end: 1.3rem;
-  background: url(../../../assets/open-in-new.svg) no-repeat center left;
-  background-size: 1rem;
-}
diff --git a/packages/keybr-widget/lib/components/text/Link.tsx b/packages/keybr-widget/lib/components/text/Link.tsx
@@ -10,7 +10,6 @@ export function Link({
   href,
   target,
   download,
-  external,
   title,
   children,
   ...props
@@ -19,7 +18,7 @@ export function Link({
     <Component
       {...props}
       id={id}
-      className={clsx(styles.root, external && styles.external, className)}
+      className={clsx(styles.root, className)}
       href={href}
       target={target}
       download={download}

diff --git a/packages/keybr-widget/lib/components/text/Link.types.ts b/packages/keybr-widget/lib/components/text/Link.types.ts
@@ -8,7 +8,6 @@ export type LinkProps = {
   readonly href?: string;
   readonly target?: string;
   readonly download?: string;
-  readonly external?: boolean;
   readonly title?: string;
   readonly children?: ReactNode;
 } & MouseProps;
diff --git a/packages/page-practice/lib/settings/lesson/BenfordProp.tsx b/packages/page-practice/lib/settings/lesson/BenfordProp.tsx
@@ -40,7 +40,6 @@ export function BenfordProp(): ReactNode {
                 <Link
                   href="https://en.wikipedia.org/wiki/Benford's_law"
                   target="_blank"
-                  external={true}
                 >
                   {chunks}
                 </Link>