From 089ed9930a5b458b894f1517212dde86b85b1e48 Mon Sep 17 00:00:00 2001
From: Aliaksandr Radzivanovich <aradzivanovich@gmail.com>
Date: Mon, 11 Nov 2024 10:16:52 +0100
Subject: [PATCH] feat: remove the external url icon form the Link component

---
 packages/keybr-widget/assets/open-in-new.svg         |  4 ----
 .../lib/components/text/Link.module.less             | 12 ------------
 packages/keybr-widget/lib/components/text/Link.tsx   |  3 +--
 .../keybr-widget/lib/components/text/Link.types.ts   |  1 -
 .../lib/settings/lesson/BenfordProp.tsx              |  1 -
 5 files changed, 1 insertion(+), 20 deletions(-)
 delete mode 100644 packages/keybr-widget/assets/open-in-new.svg

diff --git a/packages/keybr-widget/assets/open-in-new.svg b/packages/keybr-widget/assets/open-in-new.svg
deleted file mode 100644
index 7242b5235..000000000
--- a/packages/keybr-widget/assets/open-in-new.svg
+++ /dev/null
@@ -1,4 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24.00 24.00">
-    <path stroke-linejoin="round"
-          d="M 14,3L 14,5L 17.59,5L 7.76,14.83L 9.17,16.24L 19,6.41L 19,10L 21,10L 21,3M 19,19L 5,19L 5,5L 12,5L 12,3L 5,3C 3.89,3 3,3.9 3,5L 3,19C 3,20.1 3.89,21 5,21L 19,21C 20.1,21 21,20.1 21,19L 21,12L 19,12L 19,19 Z"/>
-</svg>
diff --git a/packages/keybr-widget/lib/components/text/Link.module.less b/packages/keybr-widget/lib/components/text/Link.module.less
index 8410b3795..632578026 100644
--- a/packages/keybr-widget/lib/components/text/Link.module.less
+++ b/packages/keybr-widget/lib/components/text/Link.module.less
@@ -1,15 +1,3 @@
 .root {
   /* Empty. */
 }
-
-.external:dir(ltr) {
-  padding-inline-end: 1.3rem;
-  background: url(../../../assets/open-in-new.svg) no-repeat center right;
-  background-size: 1rem;
-}
-
-.external:dir(rtl) {
-  padding-inline-end: 1.3rem;
-  background: url(../../../assets/open-in-new.svg) no-repeat center left;
-  background-size: 1rem;
-}
diff --git a/packages/keybr-widget/lib/components/text/Link.tsx b/packages/keybr-widget/lib/components/text/Link.tsx
index 646cf3ec8..a5f0f3c76 100644
--- a/packages/keybr-widget/lib/components/text/Link.tsx
+++ b/packages/keybr-widget/lib/components/text/Link.tsx
@@ -10,7 +10,6 @@ export function Link({
   href,
   target,
   download,
-  external,
   title,
   children,
   ...props
@@ -19,7 +18,7 @@ export function Link({
     <Component
       {...props}
       id={id}
-      className={clsx(styles.root, external && styles.external, className)}
+      className={clsx(styles.root, className)}
       href={href}
       target={target}
       download={download}
diff --git a/packages/keybr-widget/lib/components/text/Link.types.ts b/packages/keybr-widget/lib/components/text/Link.types.ts
index f2cad92ec..6004ccf92 100644
--- a/packages/keybr-widget/lib/components/text/Link.types.ts
+++ b/packages/keybr-widget/lib/components/text/Link.types.ts
@@ -8,7 +8,6 @@ export type LinkProps = {
   readonly href?: string;
   readonly target?: string;
   readonly download?: string;
-  readonly external?: boolean;
   readonly title?: string;
   readonly children?: ReactNode;
 } & MouseProps;
diff --git a/packages/page-practice/lib/settings/lesson/BenfordProp.tsx b/packages/page-practice/lib/settings/lesson/BenfordProp.tsx
index 2239462cf..13fa86208 100644
--- a/packages/page-practice/lib/settings/lesson/BenfordProp.tsx
+++ b/packages/page-practice/lib/settings/lesson/BenfordProp.tsx
@@ -40,7 +40,6 @@ export function BenfordProp(): ReactNode {
                 <Link
                   href="https://en.wikipedia.org/wiki/Benford's_law"
                   target="_blank"
-                  external={true}
                 >
                   {chunks}
                 </Link>